Browse Source

Add some thoughts in form of comments

master
Krisjanis Rijnieks 10 years ago
parent
commit
2ea46acbb3
  1. 6
      src/Commands/CommandManager.h
  2. 4
      src/MediaServer/MediaServer.h
  3. 11
      src/ofxPiMapper.h

6
src/Commands/CommandManager.h

@ -1,6 +1,3 @@
// CommandManager class to keep a stack of commands for undo functionality
// Created by Krisjanis Rijnieks 2015-03-24
#pragma once #pragma once
#import <deque> #import <deque>
@ -14,9 +11,12 @@ namespace ofx{
public: public:
void executeCommand(BaseCommand * cmd); void executeCommand(BaseCommand * cmd);
void undo(); void undo();
// TODO: Add redo
private: private:
std::deque<BaseUndoableCommand *> commandStack; std::deque<BaseUndoableCommand *> commandStack;
// TODO: Add redo stack
// Maybe use vector instead of deque...
}; };
} // namespace piMapper } // namespace piMapper

4
src/MediaServer/MediaServer.h

@ -13,6 +13,10 @@
#include "ofMain.h" #include "ofMain.h"
#include "DirectoryWatcher.h" #include "DirectoryWatcher.h"
/* Discussion: This could be the right place for a Factory Method or
* Abstract Factory design pattern - replace all these includes with a
* SourceFactory that can create sources with the interfaces below. */
#include "BaseSource.h" #include "BaseSource.h"
#include "ImageSource.h" #include "ImageSource.h"
#include "VideoSource.h" #include "VideoSource.h"

11
src/ofxPiMapper.h

@ -1,12 +1,5 @@
/* ofxPiMapper // ofxPiMapper
* // Author: Krisjanis Rijnieks
* Description:
* Main ofxPiMapper class. Holds instances of all necessary parts of the tool:
* - MediaServer
* - SurfaceManager
* - SurfaceManagerGui (this asks for a different architecture)
*
* Author: Krisjanis Rijnieks */
// On using prefixes like m or p (mMemberVariable, pMyPointer) // On using prefixes like m or p (mMemberVariable, pMyPointer)
// http://stackoverflow.com/questions/1228161/why-use-prefixes-on-member-variables-in-c-classes // http://stackoverflow.com/questions/1228161/why-use-prefixes-on-member-variables-in-c-classes

Loading…
Cancel
Save